tom-pytel commented on pull request #20: URL: https://github.com/apache/skywalking-nodejs/pull/20#issuecomment-752969639
> It is not perfect yet since `local` and `/doall` still end earlier but looking into it. The client `local` span early termination is an illusion, a test artifact, `downloadPage()` and `downloadPageS()` promise was resolved on `end` event and not `close`, when I change it to `close` it ends after all requests as expected. Temporal paradox resolved, everything now ends correctly. But yes, this is going to be a tricky issue in other plugins as well, hooking into the correct events and making sure of consistency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
