hanahmily commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r562305993
##########
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##########
@@ -57,11 +58,21 @@
@Override public StreamObserver<ExportMetricsServiceRequest> export(
StreamObserver<ExportMetricsServiceResponse> responseObserver) {
return new StreamObserver<ExportMetricsServiceRequest>() {
- @Override public void onNext(ExportMetricsServiceRequest request) {
+ private Node node;
+
+ @Override
+ public void onNext(ExportMetricsServiceRequest request) {
+ if (request.hasNode())
+ node = request.getNode();
Review comment:
In case of NPE, I prefer to assign a default value to the `Node`, even
node is sent in the first message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
