wu-sheng commented on a change in pull request #6243:
URL: https://github.com/apache/skywalking/pull/6243#discussion_r562307855
##########
File path:
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java
##########
@@ -107,6 +118,13 @@
return result;
}
+ private static Map<String, String> buildLabelsFromNodeInfo(Node node,
+ Map<String,
String> buildLabelsResult) {
+ if (node != null)
+ buildLabelsResult.put("node_identifier_host_name",
node.getIdentifier().getHostName());
Review comment:
```
// Identifier that uniquely identifies a process within a VM/container.
message ProcessIdentifier {
// The host name. Usually refers to the machine/container name.
// For example: os.Hostname() in Go, socket.gethostname() in Python.
string host_name = 1;
// Process id.
uint32 pid = 2;
// Start time of this ProcessIdentifier. Represented in epoch time.
google.protobuf.Timestamp start_timestamp = 3;
}
```
I think there is only `pid` makes sense? Do you think `_` is good, or should
consider `.`? Such as `node.identifier.host_name`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
