tom-pytel commented on pull request #27:
URL: https://github.com/apache/skywalking-nodejs/pull/27#issuecomment-768205646


   > After testing, if two requests are repeatedly sent in a short time, the 
subsequent requests may use the `AsyncState` initialized by the previous 
request. It is temporarily unclear why `store.enterWith(undefined as unknown as 
AsyncState)` in the `clear` method not work(The store cannot be reset), I tried 
to add an `invalid` flag, which works normally, I hope to discuss the 
feasibility of this implementation with you, thx
   
   Also, I don't see `asyncState.context.invalid` being cleared again after 
this, which would mean that once a ContextManager is marked invalid then all 
new subsequent `Span`s will get a clean `SpanContext` and the parent chain will 
be broken?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to