tom-pytel commented on pull request #27: URL: https://github.com/apache/skywalking-nodejs/pull/27#issuecomment-768224666
> According to my understanding, it will not be broken in theory, because it will be marked only when the trace ends. The subsequent span should use the new trace. Could it be said that after the `segment-finished` event is triggered, there are sub spans that have not ended or were create? > > Similarly, I think the role of the `invalid` tag is the same as `store.enterWith(undefined as unknown as AsyncState)`, both get a clean SpanContext , Is it my understanding? Ok, I understand what you are getting at but in that case you should be adding the invalid flag to the `asyncState` object and not the `SpanContext` object that it contains since that `SpanContext` may be used by other things (like parents of this `Span`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
