wu-sheng commented on a change in pull request #6266:
URL: https://github.com/apache/skywalking/pull/6266#discussion_r565261124
##########
File path:
apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java
##########
@@ -76,4 +85,10 @@ public boolean trySampling(final String operationName) {
public void forceSampled() {
super.forceSampled();
}
+
+ void handleTraceIgnorePatternsChanged() {
+ if
(StringUtil.isNotBlank(traceIgnorePatternWatcher.getTraceIgnorePathPatterns()))
{
Review comment:
What happens if I set the value as blank? I think the PR misses some
logic here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
