kezhenxu94 commented on a change in pull request #6266:
URL: https://github.com/apache/skywalking/pull/6266#discussion_r565275043
##########
File path:
apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java
##########
@@ -76,4 +85,10 @@ public boolean trySampling(final String operationName) {
public void forceSampled() {
super.forceSampled();
}
+
+ void handleTraceIgnorePatternsChanged() {
+ if
(StringUtil.isNotBlank(traceIgnorePatternWatcher.getTraceIgnorePathPatterns()))
{
Review comment:
Blank string is considered as `DELETE` event, and it will use the
default value (`TraceIgnorePatternWatcher#51`) of
`IgnoreConfig.Trace.IGNORE_PATH`, so
`traceIgnorePatternWatcher.getTraceIgnorePathPatterns()` may be effectively not
blank unless `IgnoreConfig.Trace.IGNORE_PATH` is set to empty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
