wu-sheng commented on pull request #6304:
URL: https://github.com/apache/skywalking/pull/6304#issuecomment-772129390


   > I’m +1 to add this, what I meant was we still need to find some other 
methods to enforce this.
   
   Does current checkStyle change enforce this?
   
   > It says it only checks this method commented with /** {@inheritDoc} */ 
because checkstyle is static analyzer, it cannot see a class’s parent class 
when analyzing, hence doesn’t know whether the method is overriding its 
parent’s method
   
   What does this mean to `@Override`? I read the missing `@Override` could 
cause CI failure in the style check plugin doc. I am not sure I am following.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to