wu-sheng commented on pull request #6304: URL: https://github.com/apache/skywalking/pull/6304#issuecomment-772145378
> See 👆。 > > I approve the code changes in this PR (add the missing `@Override`), but this rule only take very limited effects, does no harm though. I prefer to investigate some other dedicated tools professional at code analysis (Sonar, CodeQL, etc.) to enforce this. Agree, I just don't want this kind of PR keeps coming, because even this is correct from coding style perspective, it is not really very useful as nearly 100% people use IDE rather than text.editor to write Java codes. I have concerned people may use this kind of PR to make them having higher rank in the contributor list(not referring this one), as some people are marketing the rank position in the top level project. I will be more cautious if there is another this kind of PR happens in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
