wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571610225
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -284,6 +289,11 @@ public void prepare() throws ServiceNotProvidedException,
ModuleStartException {
TopNStreamProcessor.getInstance().setTopNWorkerReportCycle(moduleConfig.getTopNReportPeriod());
apdexThresholdConfig = new ApdexThresholdConfig(this);
ApdexMetrics.setDICT(apdexThresholdConfig);
+
+ // TCP manager
+ tcpServerManager = new TCPServerManager(moduleConfig.getTcpHost(),
+ moduleConfig.getTcpBossGroupThreadCount(),
moduleConfig.getTcpWorkerGroupThreadCount());
+ this.registerServiceImplementation(TCPBinderRegister.class, new
TCPBinderRegisterImpl(tcpServerManager));
Review comment:
Zabbix server with its TCP protocol is very unique, how this could share
with others? Could you provide a real or closing real(in theory) case to
support this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
