wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r573382286
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleConfig.java
##########
@@ -134,6 +135,19 @@
@Getter
private String searchableLogsTags = "";
+ /**
+ * TCP Server bind host.
+ */
+ private String tcpHost = "0.0.0.0";
+ /**
+ * The count of TCP boss group thread to building connection channel.
+ */
+ private int tcpBossGroupThreadCount = 1;
+ /**
+ * The count of TCP worker group thread to handle data.
+ */
+ private int tcpWorkerGroupThreadCount = 0;
+
Review comment:
This should not exist here.
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -98,6 +94,11 @@
import org.apache.skywalking.oap.server.telemetry.TelemetryModule;
import org.apache.skywalking.oap.server.telemetry.api.TelemetryRelatedContext;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+
Review comment:
You should not change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
