kezhenxu94 commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579628399
##########
File path: .github/actions/e2e-test/action.yml
##########
@@ -53,6 +53,11 @@ runs:
- name: Run E2E Test
shell: bash
run: |
+ echo "::group::Install SNAPSHOT apm-application-toolkit"
+ ./mvnw -DskipTests -N install
+ ./mvnw -f apm-application-toolkit -DskipTests -am install
+ echo "::endgroup::"
Review comment:
> Then, we will face the test will fail in official release tag.
Today we are already facing this case,
[example](https://github.com/apache/skywalking/pull/6380). I just can see any
downside of this PR but benefits I mentioned above
##########
File path: .github/actions/e2e-test/action.yml
##########
@@ -53,6 +53,11 @@ runs:
- name: Run E2E Test
shell: bash
run: |
+ echo "::group::Install SNAPSHOT apm-application-toolkit"
+ ./mvnw -DskipTests -N install
+ ./mvnw -f apm-application-toolkit -DskipTests -am install
+ echo "::endgroup::"
Review comment:
> Then, we will face the test will fail in official release tag.
Today we are already facing this case,
[example](https://github.com/apache/skywalking/pull/6380). I just can't see any
downside of this PR but benefits I mentioned above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
