kezhenxu94 commented on a change in pull request #6403:
URL: https://github.com/apache/skywalking/pull/6403#discussion_r579651658
##########
File path: .github/actions/e2e-test/action.yml
##########
@@ -53,6 +53,11 @@ runs:
- name: Run E2E Test
shell: bash
run: |
+ echo "::group::Install SNAPSHOT apm-application-toolkit"
+ ./mvnw -DskipTests -N install
+ ./mvnw -f apm-application-toolkit -DskipTests -am install
+ echo "::endgroup::"
Review comment:
> that is why I don't want it happens again.
There is no guarantee that it won't happened again unless we decided not to
do SNAPSHOT releases for testing. Also, using a previous version (8.4.0) in PR
tests makes no sense to me, even if we don't test format here, it acts as a
regression test that it doesn't break the non-format logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
