tianyk commented on pull request #45: URL: https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791886009
I suggest whitelisting and blocking only the services we care about. Not all origins. 吴晟 Wu Sheng <[email protected]>于2021年3月6日 周六14:50写道： > There are some suggestions for this. 1. For the SDK name, could you change originAllowlist > to NoTraceOrigins and update the corresponding logic? 2. It is fine that > the type of originAllowlist is (string | RegExp)[]. 3. the default value > of originAllowlist is []. > WDYT? @wu-sheng <https://github.com/wu-sheng> @kezhenxu94 > <https://github.com/kezhenxu94> @tianyk <https://github.com/tianyk> > > Use blockList if you want. I am +1 to use blocking rather than allowing > mechanism. In this case, empty meaning all available makes more sense to me. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791885250>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAZ3CNSQLL7V762AIUCTLI3TCHGCRANCNFSM4YURSEZQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
