tianyk commented on pull request #45: URL: https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791886759
Zhenxu Ke <[email protected]>于2021年3月6日 周六15:00写道： > There are some suggestions for this. 1. For the SDK name, could you change originAllowlist > to NoTraceOrigins and update the corresponding logic? 2. It is fine that > the type of originAllowlist is (string | RegExp)[]. 3. the default value > of originAllowlist is []. > > WDYT? @wu-sheng <https://github.com/wu-sheng> @kezhenxu94 > <https://github.com/kezhenxu94> @tianyk <https://github.com/tianyk> > > Use blockList if you want. I am +1 to use blocking rather than allowing > mechanism. In this case, empty meaning all available makes more sense to me. > > Blocking mechanism requires that you must list all uncontrollable domains, > some of which may be unknown, allowlist is more preferable in this case > sonar you know which domains you own / control > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791886273>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAZ3CNRCFUY4RI547WKVXH3TCHHHBANCNFSM4YURSEZQ> > . > That's what I mean. Sometimes we don't know all of origins, especially when using third party services. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
