wu-sheng commented on a change in pull request #6763:
URL: https://github.com/apache/skywalking/pull/6763#discussion_r614039150
##########
File path:
oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/ZipkinReceiverConfig.java
##########
@@ -33,4 +36,5 @@
private long jettyIdleTimeOut = 30000;
private int jettyAcceptorPriorityDelta = 0;
private int jettyAcceptQueueSize = 0;
+ private List<String> instanceNameRule = new ArrayList<>();
Review comment:
Could you add a unit test to verify? I can't find the test about this
for now. And existing codes use string, and then convert to list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
