klboke commented on a change in pull request #6763:
URL: https://github.com/apache/skywalking/pull/6763#discussion_r614510923
##########
File path:
oap-server/server-storage-plugin/storage-zipkin-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/zipkin/elasticsearch/ZipkinTraceQueryEs7DAO.java
##########
@@ -211,9 +214,14 @@ public TraceBrief queryBasicTraces(long startSecondTB,
});
if (StringUtil.isNotEmpty(serviceId)) {
final IDManager.ServiceID.ServiceIDDefinition
serviceIDDefinition = IDManager.ServiceID.analysisId(
- serviceId);
+ serviceId);
swSpan.setServiceCode(serviceIDDefinition.getName());
}
+ if (StringUtil.isNotEmpty(serviceInstanceId)) {
Review comment:
```
type Span {
traceId: ID!
segmentId: ID!
spanId: Int!
parentSpanId: Int!
refs: [Ref!]!
serviceCode: String!
serviceInstanceName: ID!
startTime: Long!
endTime: Long!
endpointName: String
# There are three span types: Local, Entry and Exit
type: String!
# Peer network id, e.g. host+port, ip+port
peer: String
component: String
isError: Boolean
# There are 5 layers: Unknown, Database, RPCFramework, Http, MQ and Cache
layer: String
tags: [KeyValue!]!
logs: [LogEntity!]!
}
```
The processing logic here is just to be consistent with the serviceId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
