kezhenxu94 commented on a change in pull request #51:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618452075
##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
// The sidecar/proxy internal error code, the value bases on the
implementation.
// The envoy internal error codes are listed here,
https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
string internalErrorCode = 14;
+
+ // The throughput detail of the mesh metrics.
+ Throughput throughput = 15;
Review comment:
> But we have OAL related to the latency, if you share the existing one,
I think the metrics there would be wrong.
Both of Tcp and Http share the same field `latency`, that said, for TCP,
`latency = round trip time`, for HTTP it's what it is now, do you mean the
latency would be counted twice for Tcp services? If so, it is not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
