chenmudu commented on pull request #6888:
URL: https://github.com/apache/skywalking/pull/6888#issuecomment-831166290


   > 1. If you take a look at UI, we could query all scopes' alarm messages. So 
this kind of filter is pointless.
   
   Cpoy, thanks. I understand that the incorrect place should be in the 
EventQueryCondition (sorry that I ignored the filter item on UI). I should 
enrich the EventQueryCondition according to Scope and reduce other meaningless 
event data from the query. 
   
   > 2. We are only querying limited alarms at one time, so, we could 
definitely query related events after we have the alarm list.
   
   Why don't we query all Alarm (there may be some other filters) and then let 
the user select the event list for a single Alarm in the Alarm List? Instead of 
including Events in each Alarm while querying the current Alarm list. I don't 
know if it's getting easier, but I'd like your advice.  Maybe I haven't seen 
the UI, so I'm not sure which is the final query mode.
   
   Thanks a lot. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to