chenmudu edited a comment on pull request #6888: URL: https://github.com/apache/skywalking/pull/6888#issuecomment-831345375
> You were proposing the query protocol, with the event included in the alarm. Why are you asking me about this? If you are thinking about 2 steps query, why we haven't discussed this at the protocol level. Sorry, it was only after I received the request to narrow the scope of the query that I looked at the code and found that the current single-step query mode seemed unable to construct the query condition completely(The query criteria only have the **Scope Type**, without the **Source values**.). This is one of the reasons why I brought up the topic of a two-step query. Another reason is that it seems like a bad way to query the Alarm list first and then construct different EventQueryCondition (populating the Source) to query the corresponding Event list (multiple queries, and there is no concept of transactions).Of course, this way can also achieve a single step query all. So I would like to confirm with you: 1. The first way： I might need to roll back the query-protocol to the previous version, undo the code that I want to merge this time, and then break it into two steps and let the UI query it. 2. The second way is that I don't need to roll back query-protocol and use a single step to query all of them, but that doesn't seem to be a good way to do it. We need to choose one of these two ways. Personally, I prefer 1. I don't know what your suggestion is. I am so sorry that my mistake has caused unnecessary work for you and @kezhenxu94 . 😅 if there are some problems in my way of asking questions, thanks for helping me to point out. I just want to do something to make SkyWalking to be better. 💗Thanks for your reply.I'll pay attention next time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
