wu-sheng commented on pull request #50:
URL: https://github.com/apache/skywalking-nodejs/pull/50#issuecomment-839781398


   > > > Which sampling mechanism are you referring to?
   > > 
   > > 
   > > I mean, this is actually a sampling mechanism. Typically, it is called 
adaptive sampling. Because sampling bases on the volume of network and backend 
capabilities.
   > 
   > You mean the "throttling" or "limiting" mechanism I changed? Doesn't 
matter what its called, it is settable, it uses the same 
`SW_AGENT_MAX_BUFFER_SIZE` or `config.maxBufferSize` to set the sampling size 
as the previous method, so no change there.
   
   I think should have a setting called `config.sampling=adaptive`, then your 
codes work. Also, we could extend to have `config-sampling=rate` etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to