tom-pytel commented on pull request #50: URL: https://github.com/apache/skywalking-nodejs/pull/50#issuecomment-840049034
@kezhenxu94: I've added two small cleanups: * Moved `ContextManager.spansDup()` from the `Context.new?Span()` functions to the `Context.start()` function to be more symmetric with `stop()`, `async()` and `resync()` but also because the `spansDup()` needs to happen before the `spans.push()` and there is no guarantee the user will call `start()` just after the `Context.new?Span()` call. * Removed the `Buffer` class since without the size check it is just a wrapper for a JS array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
