ascrutae commented on issue #2827: Improve ContextManager class of sniffer 
module
URL: https://github.com/apache/skywalking/pull/2827#issuecomment-498984806
 
 
   This PR will affect the other plugin which uses RuntimeContext. The 
principle of clear `RunTimeContext` is who stores, who cleans up.  So I don't 
agree with clear it in `stopSpan` method.
   
   and It seems like the spring plugins had a memory leak.  I think this issue 
should be fixed in the Spring plugin, not in the core jar.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to