ascrutae commented on issue #2827: Improve ContextManager class of sniffer 
module
URL: https://github.com/apache/skywalking/pull/2827#issuecomment-499002979
 
 
   I had check the code and found that theStackDepth had store in 
RuntimeContext andthere is no thread share scenario in Spring plugin.
   
   
   Original Message
   Sender:吴晟 Wu [email protected]
   Recipient:apache/[email protected]
   Cc:Zhang" [email protected]; [email protected]
   Date:Wednesday, Jun 5, 2019 16:55
   Subject:Re: [apache/skywalking] Improve ContextManager class of 
sniffermodule (#2827)
   
   
   I am not following, what is the original issue? Is the TracingContext, 
RunningContext or something else. This change should not need in any case.
   @ascrutae running context is threadlocal based, there is no thread share 
scenario.
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or mute the thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to