wu-sheng commented on pull request #7194: URL: https://github.com/apache/skywalking/pull/7194#issuecomment-870204884
2 arguments about this kind of changes. 1. Instance is up and down, with scaling. The name of instance could/should change from time to time, especially in today's k8s deployment. I can't see the point of set sampling for a single instance. 2. About endpoint, a.k.a. your interface. This would be a huge number of sampling, and as this sampler has to keep the seed for every endpoint(URI), if URI is parameterized, your OAP will be OOM eventually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
