HendSame commented on pull request #7194:
URL: https://github.com/apache/skywalking/pull/7194#issuecomment-871135518
> 2 arguments about this kind of changes.
>
> 1. Instance is up and down, with scaling. The name of instance
could/should change from time to time, especially in today's k8s deployment. I
can't see the point of set sampling for a single instance.
> 2. About endpoint, a.k.a. your interface. This would be a huge number of
sampling, and as this sampler has to keep the seed for every endpoint(URI), if
URI is parameterized, your OAP will be OOM eventually.
In my opinion, there are some premises of this usage scenario about the tow
arguments:
- Maybe in our performance testing environment, it will be of great help to
us in troubleshooting performance problems when doing full-link performance
tests, that is also a good support point for full-link monitoring to full-link
pressure testing.And at the same time, we usually only configure endpoint
sampling rate for endpoints according to our needs .
- Or it could be that some instance of our production environment has an
exception at that point in time. Of course, in most scenarios, the priority is
to fix the problem and keep one or two instances in exception for
troubleshooting.
- `URI is parameterized`,I remember that if URI is parameterized, it will
be a parameterized URI as the span's `enpointName` such as :
`{POST}/urlpath/{id}`.
So I think should pay more attention to usage scenarios.And I think this is
a kind of ability we should provide, and how to use it depends on the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
