[GitHub] [skywalking-data-collect-protocol] Ax1an commented on a change in pull request #52: add some new thread metric and class metric to JVMMetric

Fri, 02 Jul 2021 05:00:13 -0700 


Ax1an commented on a change in pull request #52:
URL: 
https://github.com/apache/skywalking-data-collect-protocol/pull/52#discussion_r662960060



##########
File path: language-agent/JVMMetric.proto
##########
@@ -84,9 +85,25 @@ enum GCPhrase {
     OLD = 1;
 }
 
+// see: 
https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html
 message Thread {
-  int64 liveCount = 1;
-  int64 daemonCount = 2;
-  int64 peakCount = 3;
+    int64 liveCount = 1;
+    int64 daemonCount = 2;
+    int64 peakCount = 3;
+    int64 deadlockedCount = 4;
+    int64 monitorDeadlockedCount = 5;

Review comment:
       I found that this place may have relatively large performance loss.
   
   
![image](https://user-images.githubusercontent.com/28091237/124271315-e7199b80-db6f-11eb-9d38-e2b3543ea4d6.png)
   
   
![image](https://user-images.githubusercontent.com/28091237/124271436-0a444b00-db70-11eb-8329-d0865867da14.png)
   
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to