wu-sheng commented on a change in pull request #52:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/52#discussion_r662983566
##########
File path: language-agent/JVMMetric.proto
##########
@@ -84,9 +85,25 @@ enum GCPhrase {
OLD = 1;
}
+// see:
https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html
message Thread {
- int64 liveCount = 1;
- int64 daemonCount = 2;
- int64 peakCount = 3;
+ int64 liveCount = 1;
+ int64 daemonCount = 2;
+ int64 peakCount = 3;
+ int64 deadlockedCount = 4;
+ int64 monitorDeadlockedCount = 5;
Review comment:
It seems deadlock metrics should not be added to a period reporter, this
impacts performance a lot.
OAP could support a dynamic configuration to create a deadlock check task
and report separately through other APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
