wu-sheng commented on pull request #7235: URL: https://github.com/apache/skywalking/pull/7235#issuecomment-872953051
Hi, you need to follow at least these points 1. Cache plugin should be in the optional list. I noticed `ehcache` plugin in the default plugin, which is a mistake. @mrproliu Look like it was contributed by you, could you move it to an optional plugin with doc updates? 2. Follow the plugin dev doc's last section, we require plugin integration test like all other plugins 3. Documents, `Plugin-list.md`(related to CI process), `Supported-list.md`, and `changes.md` should be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
