wu-sheng commented on a change in pull request #7235: URL: https://github.com/apache/skywalking/pull/7235#discussion_r664160723
########## File path: apm-sniffer/optional-plugins/guava-cache-plugin/pom.xml ########## @@ -17,28 +17,34 @@ ~ --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> <parent> <groupId>org.apache.skywalking</groupId> <artifactId>optional-plugins</artifactId> <version>8.7.0-SNAPSHOT</version> </parent> + + <artifactId>guava-cache-plugin</artifactId> + <name>guava-cache-plugin</name> + <packaging>jar</packaging> + <modelVersion>4.0.0</modelVersion> - <artifactId>apm-sentinel-1.x-plugin</artifactId> - <name>sentinel-1.x-plugin</name> - <url>http://maven.apache.org</url> <properties> - <sentinel-core.version>1.7.2</sentinel-core.version> + <guava-client.version>23.0</guava-client.version> </properties> <dependencies> + <dependency> - <groupId>com.alibaba.csp</groupId> - <artifactId>sentinel-core</artifactId> - <version>${sentinel-core.version}</version> + <groupId>com.google.guava</groupId> + <artifactId>guava</artifactId> + <version>${guava-client.version}</version> <scope>provided</scope> </dependency> + </dependencies> + Review comment: As you support 18-23, could we use 23 in the compiling level. I know this could cause a CVE issue, but it is better to reduce confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
