Ax1an commented on a change in pull request #52:
URL: 
https://github.com/apache/skywalking-data-collect-protocol/pull/52#discussion_r663031920



##########
File path: language-agent/JVMMetric.proto
##########
@@ -84,9 +85,23 @@ enum GCPhrase {
     OLD = 1;
 }
 
+// see: 
https://docs.oracle.com/javase/8/docs/api/java/lang/management/ThreadMXBean.html
 message Thread {
-  int64 liveCount = 1;
-  int64 daemonCount = 2;
-  int64 peakCount = 3;
+    int64 liveCount = 1;
+    int64 daemonCount = 2;
+    int64 peakCount = 3;
+    int64 newStateThreadCount = 4;
+    int64 runnableStateThreadCount = 5;
+    int64 blockedStateThreadCount = 6;
+    int64 waitingStateThreadCount = 7;
+    int64 timedWaitingStateThreadCount = 8;
+    int64 terminatedStateThreadCount = 9;
+}
+
+// see: 
https://docs.oracle.com/javase/8/docs/api/java/lang/management/ClassLoadingMXBean.html

Review comment:
       ```suggestion
   // See: 
https://docs.oracle.com/javase/8/docs/api/java/lang/management/ClassLoadingMXBean.html
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to