Switch-vov commented on a change in pull request #7243:
URL: https://github.com/apache/skywalking/pull/7243#discussion_r664535161
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/jvm/JVMSourceDispatcher.java
##########
@@ -193,7 +197,29 @@ private void sendToThreadMetricProcess(String service,
serviceInstanceJVMThread.setLiveCount(thread.getLiveCount());
serviceInstanceJVMThread.setDaemonCount(thread.getDaemonCount());
serviceInstanceJVMThread.setPeakCount(thread.getPeakCount());
+
serviceInstanceJVMThread.setRunnableStateThreadCount(thread.getRunnableStateThreadCount());
+
serviceInstanceJVMThread.setBlockedStateThreadCount(thread.getBlockedStateThreadCount());
+
serviceInstanceJVMThread.setWaitingStateThreadCount(thread.getWaitingStateThreadCount());
+
serviceInstanceJVMThread.setTimedWaitingStateThreadCount(thread.getTimedWaitingStateThreadCount());
Review comment:
> The compatibility test is not using the latest agent, it checks the
compatibility with the previous release. I remember it uses 8.2 or 8.1 release
agent. In that agent, you don't have these metrics. You should make that e2e
test verifier doesn't check these added metrics.
>
> My point was, you may need to check whether has errors here because the
data OAP received in this case, they even don't report all these fields. Now, I
think you could ignore my comments about `You may use hasField to determine the
version.`, protobuf should have covered this case, and focus on different
metrics verification in different test cases.
So, should I delete there test-case of metrics in e2e?
In addition, What need I do about test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
