kezhenxu94 commented on a change in pull request #7243:
URL: https://github.com/apache/skywalking/pull/7243#discussion_r664971098
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/jvm/JVMSourceDispatcher.java
##########
@@ -193,7 +197,29 @@ private void sendToThreadMetricProcess(String service,
serviceInstanceJVMThread.setLiveCount(thread.getLiveCount());
serviceInstanceJVMThread.setDaemonCount(thread.getDaemonCount());
serviceInstanceJVMThread.setPeakCount(thread.getPeakCount());
+
serviceInstanceJVMThread.setRunnableStateThreadCount(thread.getRunnableStateThreadCount());
+
serviceInstanceJVMThread.setBlockedStateThreadCount(thread.getBlockedStateThreadCount());
+
serviceInstanceJVMThread.setWaitingStateThreadCount(thread.getWaitingStateThreadCount());
+
serviceInstanceJVMThread.setTimedWaitingStateThreadCount(thread.getTimedWaitingStateThreadCount());
Review comment:
Yes. @Switch-vov don’t share compatibility test class with simple case,
copy `SimpleE2E` class for compatibility (`ComparE2E`) and replace
https://github.com/apache/skywalking/blob/d15b67bd97cfe8386df0c61198d9f1ca2060089b/.github/workflows/e2e.compat.yaml#L61
with the `CompatE2E` class. Then in `CompatE2E` don’t verify those new
metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
