hanahmily commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-banyandb/pull/20#discussion_r672810242



##########
File path: pkg/query/logical/plan_indexscan.go
##########
@@ -107,12 +108,13 @@ type indexScan struct {
 }
 
 func (i *indexScan) Execute(ec executor2.ExecutionContext) ([]data.Entity, 
error) {
-       var chunkSet common.ChunkIDs
+       var chunkSet posting.List
        for _, exprs := range i.conditionMap {
                // TODO: Discuss which metadata should be used!

Review comment:
       @lujiajing1126 IndexRule metadata should be selected here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to