lujiajing1126 commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-banyandb/pull/20#discussion_r673614078



##########
File path: pkg/query/logical/plan_indexscan.go
##########
@@ -107,12 +108,13 @@ type indexScan struct {
 }
 
 func (i *indexScan) Execute(ec executor2.ExecutionContext) ([]data.Entity, 
error) {
-       var chunkSet common.ChunkIDs
+       var chunkSet posting.List
        for _, exprs := range i.conditionMap {
                // TODO: Discuss which metadata should be used!

Review comment:
       But as I understand, a IndexRule probably can be bounded to several 
Series. So there is a 1:N relationship between IndexRule and Series




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to