wu-sheng commented on pull request #7363:
URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885618138


   > The existing plugin enhances rabbitmq java client interface so it works 
for all rabbitmq client implementations. But this plugin only enhances the 
implementation of rabbitmq client in spring. When a spring application calling 
rabbitmq, both plugins can be active. But for clients other than spring, this 
one will not be active. That's why we can't replace the existing one.
   > 
   > 
   > 
   > I hope I've made myself clear.:sweat_smile:
   
   This explained why you need one, but doesn't explain why you need a new one. 
You said, the existing plugin works for all case, including through Spring, 
then why need this?
   
   The key point I keep asking is, why this has to be optional? Why can't 
optimize it to work in default and only necessary when existing plugin doesn't 
work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to