qsliu2017 commented on pull request #7363: URL: https://github.com/apache/skywalking/pull/7363#issuecomment-885634819
> > The existing plugin enhances rabbitmq java client interface so it works for all rabbitmq client implementations. But this plugin only enhances the implementation of rabbitmq client in spring. When a spring application calling rabbitmq, both plugins can be active. But for clients other than spring, this one will not be active. That's why we can't replace the existing one. > > I hope I've made myself clear.😅 > > This explained why you need one, but doesn't explain why you need a new one. You said, the existing plugin works for all case, including through Spring, then why need this? > > The key point I keep asking is, why this has to be optional? Why can't optimize it to work in default and only necessary when existing plugin doesn't work. As said in #2719, the existing rabbitmq plugin divides a total trace into two parts because of the internals of rabbitmq. I need a new one which can make a trace complete. This plugin can fix it but **only** in spring. I haven't found a way to disable the existing one automatically when this plugin is active.😅 So I put it in optional plugins, to not make duplicate spans but give users an option to replace the existing plugin manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
