lujiajing1126 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-banyandb/pull/30#discussion_r684573434
##########
File path: banyand/liaison/data/x509/ca_cert.pem
##########
@@ -0,0 +1,34 @@
+-----BEGIN CERTIFICATE-----
Review comment:
Do we need to include certs in the code base?
I suppose it would be better if they can be generated from `Makefile`?
##########
File path: banyand/liaison/grpc/grpc.go
##########
@@ -19,31 +19,54 @@ package grpc
import (
"context"
+ "flag"
+ "fmt"
+ "io"
+ "log"
"net"
+ "strings"
+ "time"
- "google.golang.org/grpc"
+ "github.com/pkg/errors"
+ grpclib "google.golang.org/grpc"
+ "google.golang.org/grpc/credentials"
+ "github.com/apache/skywalking-banyandb/api/common"
+ "github.com/apache/skywalking-banyandb/api/data"
"github.com/apache/skywalking-banyandb/api/event"
v1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/v1"
+ apischema "github.com/apache/skywalking-banyandb/api/schema"
"github.com/apache/skywalking-banyandb/banyand/discovery"
+ serverData "github.com/apache/skywalking-banyandb/banyand/liaison/data"
"github.com/apache/skywalking-banyandb/banyand/queue"
"github.com/apache/skywalking-banyandb/pkg/bus"
+ "github.com/apache/skywalking-banyandb/pkg/convert"
"github.com/apache/skywalking-banyandb/pkg/logger"
+ "github.com/apache/skywalking-banyandb/pkg/partition"
+ "github.com/apache/skywalking-banyandb/pkg/query/logical"
"github.com/apache/skywalking-banyandb/pkg/run"
)
+var (
+ tls = flag.Bool("tls", false, "Connection uses TLS if true, else
plain TCP")
Review comment:
As I understand, the flags should be defined in the `func (s *Server)
FlagSet() *run.FlagSet`? @hanahmily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
