lujiajing1126 commented on a change in pull request #30:
URL: https://github.com/apache/skywalking-banyandb/pull/30#discussion_r684878006
##########
File path: banyand/liaison/grpc/grpc.go
##########
@@ -128,3 +158,90 @@ func (s *Server) GracefulStop() {
s.log.Info().Msg("stopping")
s.ser.GracefulStop()
}
+
+func assemblyWriteData(shardID uint, writeEntity *v1.WriteRequest, seriesID
uint64) data.TraceWriteDate {
+ return data.TraceWriteDate{ShardID: shardID, SeriesID: seriesID,
WriteRequest: writeEntity}
+}
+
+func (s *Server) Write(TraceWriteServer v1.TraceService_WriteServer) error {
+ for {
+ writeEntity, err := TraceWriteServer.Recv()
+ if err == io.EOF {
+ return nil
+ }
+ if err != nil {
+ return err
+ }
+
+ ana := logical.DefaultAnalyzer()
+ metadata := common.Metadata{
+ KindVersion: apischema.SeriesKindVersion,
+ Spec: writeEntity.GetMetadata(),
+ }
+ schema, ruleError := ana.BuildTraceSchema(context.TODO(),
metadata)
+ if ruleError != nil {
+ return ruleError
+ }
+ s.seriesInfo.RWMutex.RLock()
Review comment:
You have to release the read lock if it steps into
`s.seriesInfo.seriesEvent == nil` condition
##########
File path: banyand/liaison/grpc/grpc.go
##########
@@ -128,3 +158,90 @@ func (s *Server) GracefulStop() {
s.log.Info().Msg("stopping")
s.ser.GracefulStop()
}
+
+func assemblyWriteData(shardID uint, writeEntity *v1.WriteRequest, seriesID
uint64) data.TraceWriteDate {
+ return data.TraceWriteDate{ShardID: shardID, SeriesID: seriesID,
WriteRequest: writeEntity}
+}
+
+func (s *Server) Write(TraceWriteServer v1.TraceService_WriteServer) error {
+ for {
+ writeEntity, err := TraceWriteServer.Recv()
+ if err == io.EOF {
+ return nil
+ }
+ if err != nil {
+ return err
+ }
+
+ ana := logical.DefaultAnalyzer()
+ metadata := common.Metadata{
+ KindVersion: apischema.SeriesKindVersion,
+ Spec: writeEntity.GetMetadata(),
+ }
+ schema, ruleError := ana.BuildTraceSchema(context.TODO(),
metadata)
+ if ruleError != nil {
+ return ruleError
+ }
+ s.seriesInfo.RWMutex.RLock()
+ if s.seriesInfo.seriesEvent == nil {
+ return ErrSeriesEvents
+ }
+ var str string
+ var arr []string
+ fieldRefs, errField :=
schema.CreateRef(s.seriesInfo.seriesEvent.FieldNamesCompositeSeriesId...)
+ s.seriesInfo.RWMutex.RUnlock()
+ if errField != nil {
+ return errField
+ }
+ for _, ref := range fieldRefs {
+ field :=
writeEntity.GetEntity().GetFields()[ref.Spec.Idx]
+ switch v := field.GetValueType().(type) {
+ case *v1.Field_StrArray:
+ for j := 0; j < len(v.StrArray.Value); j++ {
+ arr = append(arr, v.StrArray.Value[j])
+ }
+ case *v1.Field_IntArray:
+ for t := 0; t < len(v.IntArray.Value); t++ {
+ arr = append(arr,
fmt.Sprint(v.IntArray.Value[t]))
+ }
+ case *v1.Field_Int:
+ arr = append(arr, fmt.Sprint(v.Int.Value))
+ case *v1.Field_Str:
+ arr = append(arr, fmt.Sprint(v.Str.Value))
+ }
+ }
+ str = strings.Join(arr, "")
+ if str == "" {
+ return ErrInvalidSeriesID
+ }
+ seriesID := []byte(str)
+ s.shardInfo.RWMutex.RLock()
Review comment:
Same here
##########
File path: banyand/liaison/grpc/grpc.go
##########
@@ -102,7 +132,9 @@ func (s *Server) Name() string {
}
func (s *Server) FlagSet() *run.FlagSet {
+ size := 1024 * 1024 * 8
fs := run.NewFlagSet("grpc")
+ fs.Int("maxRecMsgSize", size, "the size of max receiving message")
Review comment:
where do we use this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
