wu-sheng commented on a change in pull request #7431:
URL: https://github.com/apache/skywalking/pull/7431#discussion_r685961672



##########
File path: .licenserc.yaml
##########
@@ -63,5 +63,6 @@ header:
     - '**/src/main/proto/protoc-gen-swagger/**'
     - '**/src/main/proto/validate/validate.proto'
     - '**/src/main/proto/opencensus/**'
+    - '**/*.textproto'

Review comment:
       This is incorrect move. 2 questions
   1. Why `textproto` rather than proto? What format are we using?
   2. Why don't add comments for ASF LICENSE header?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to