wu-sheng commented on pull request #7431: URL: https://github.com/apache/skywalking/pull/7431#issuecomment-895997297
One important suggestion before I am going deeply in code review. As a database client(we may need to release it separate one day), we need to organize codes and keep the concept consistent. - Schema is usually referencing a database. - Table/Index/Entity is the object we are going to write and read. - Client is the one controlling the connection. We could have typically SimpleClient or BatchClient to deal with different data model. Or add QueryClient in the future. - All read/write/query should be organized on the top of different entity, which is the normal case. Take a reference from InfluxDB or ElasticSearch client. Such as, TraceWrite should be an object could host the fields and tags. It also could be accepted by BatchClient only. All above are not mandatory, but I hope these could inspire you that, this is a very serious set of APIs, we need to make it good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
