wu-sheng commented on a change in pull request #7431:
URL: https://github.com/apache/skywalking/pull/7431#discussion_r686071760
##########
File path: .licenserc.yaml
##########
@@ -63,5 +63,6 @@ header:
- '**/src/main/proto/protoc-gen-swagger/**'
- '**/src/main/proto/validate/validate.proto'
- '**/src/main/proto/opencensus/**'
+ - '**/*.textproto'
Review comment:
What we did in BanyanDB, we doesn't care here. What is the schema, we
doesn't care here.
SkyWalking is a user for BanyanDB, we only care about the HTTP client APIs,
and network protocol. That is all.
Keep this in mind, these are all we cared about. These are low level APIs.
https://github.com/apache/skywalking-banyandb/blob/b7845b0cd9fbebf71d3fc990ad6eae5f3ec16771/api/proto/banyandb/v1/rpc.proto#L29-L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
