lujiajing1126 commented on a change in pull request #7431: URL: https://github.com/apache/skywalking/pull/7431#discussion_r686072088
########## File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/client/BanyanDBSchemaMapper.java ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.storage.plugin.banyandb.client; + +import com.google.protobuf.ByteString; +import com.google.protobuf.NullValue; +import com.google.protobuf.Timestamp; +import org.apache.skywalking.banyandb.Write; +import org.apache.skywalking.oap.server.core.analysis.manual.searchtag.Tag; +import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; + +public class BanyanDBSchemaMapper implements Function<SegmentRecord, Write.EntityValue> { + private static final String TAG_PREFIX = "tags."; + + private final Set<String> schemaKeys; + /** + * Map the key defined in BanyanDB schema (i.e. *.textproto) to the field name in the {@link SegmentRecord} + */ + private static final Map<String, String> KEY_MAPPING = new HashMap<>(); + + static { + // Known mapping + // 1) duration -> latency + // 2) state -> is_error + // others: + // http.method, status_code, db.type, db.instance, mq.queue, mq.broker, mq.topic + KEY_MAPPING.put("duration", SegmentRecord.LATENCY); + KEY_MAPPING.put("state", SegmentRecord.IS_ERROR); + KEY_MAPPING.put("http.method", TAG_PREFIX + "http.method"); + KEY_MAPPING.put("status_code", TAG_PREFIX + "status_code"); + KEY_MAPPING.put("db.type", TAG_PREFIX + "db.type"); + KEY_MAPPING.put("db.instance", TAG_PREFIX + "db.instance"); + KEY_MAPPING.put("mq.queue", TAG_PREFIX + "mq.queue"); + KEY_MAPPING.put("mq.broker", TAG_PREFIX + "mq.broker"); + KEY_MAPPING.put("mq.topic", TAG_PREFIX + "mq.topic"); + } + + /** + * Map the key defined in BanyanDB schema to the Factory Lambda which can be invoked to build the Field + */ + private final Map<String, Function<Map<String, Object>, Write.Field>> fieldsMap = new HashMap<>(); + + public BanyanDBSchemaMapper(Set<String> schemaKeys) { + this.schemaKeys = schemaKeys; + + // iterate over keys in the schema + for (final String key : schemaKeys) { + fieldsMap.put(key, entityMap -> buildField(entityMap.get(KEY_MAPPING.getOrDefault(key, key)))); + } + } + + @Override + public Write.EntityValue apply(SegmentRecord segmentRecord) { + final Map<String, Object> objectMap = entity2Storage(segmentRecord); + + return Write.EntityValue.newBuilder() + .addAllFields(this.schemaKeys.stream().map(s -> fieldsMap.get(s).apply(objectMap)).collect(Collectors.toList())) + .setDataBinary(ByteString.copyFrom(segmentRecord.getDataBinary())) + .setTimestamp(Timestamp.newBuilder().setSeconds(segmentRecord.getTimeBucket()).build()) + .setEntityId(segmentRecord.getSegmentId()).build(); + } + + static Write.Field buildField(Object value) { + if (value == null) { + return Write.Field.newBuilder().setNull(NullValue.NULL_VALUE).build(); + } + if (value instanceof String) { + return Write.Field.newBuilder().setStr(Write.Str.newBuilder().setValue((String) value).build()).build(); + } else if (value instanceof Integer) { + return Write.Field.newBuilder().setInt(Write.Int.newBuilder().setValue((Integer) value).build()).build(); + } else if (value instanceof Long) { + return Write.Field.newBuilder().setInt(Write.Int.newBuilder().setValue((Long) value).build()).build(); + } else { + throw new IllegalStateException("should not reach here"); + } + } + + static Map<String, Object> entity2Storage(SegmentRecord segmentRecord) { Review comment: The basic ideas here are, 1. We do not need to encode/decode binary in Base64 format, which may cause performance issue, 2. Some of the tags have to be treated as indexed field as they are defined explicity in the schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
