HendSame commented on pull request #7554:
URL: https://github.com/apache/skywalking/pull/7554#issuecomment-906899392


   @wu-sheng  
   
   `sampleRate` and `slowTraceSegmentThreshold` are default configs. 
   
   I think they can  be removed in `AnalyzerModuleConfig`.   And  the default 
value been set in `SampleRateSetting`. 
   
   ```
    @ToString
       public static class SampleRateSetting {
           @Getter
           @Setter
           private int defaultRate = 10000;
           @Getter
           @Setter
           private int defaultDuration = -1;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to