wu-sheng commented on pull request #7554:
URL: https://github.com/apache/skywalking/pull/7554#issuecomment-906903786
> @wu-sheng
>
> `sampleRate` and `slowTraceSegmentThreshold` are default configs.
>
> I think they can be removed in `AnalyzerModuleConfig`. And the default
value been set in `SampleRateSetting`.
>
> ```
> @ToString
> public static class SampleRateSetting {
> @Getter
> @Setter
> private int defaultRate = 10000;
> @Getter
> @Setter
> private int defaultDuration = -1;
> ```
We should not keep them. You have move the default value into the
configuration file. If you want to keep hard coded default value(just in case
configuration file gets changed unexpectedly), it is fine. Meanwhile, we should
not keep those in module provider config, which means we open them to end user,
but from your design and document, they are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
