wankai123 opened a new pull request #7606:
URL: https://github.com/apache/skywalking/pull/7606
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [X] Explain briefly why the bug exists and how to fix it.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
In `ConfigWatcherRegister.singleConfigsSync()`, when config is deleted and
`watcher.value()` is not null, core would notify watcher every syncPeriod time.
``` java
ConfigChangeWatcher watcher = holder.getWatcher();
String newItemValue = item.getValue();
if (newItemValue == null) {
if (watcher.value() != null) {
// Notify watcher, the new value is null with delete
event type.
watcher.notify(
new ConfigChangeWatcher.ConfigChangeEvent(null,
ConfigChangeWatcher.EventType.DELETE));
} else {
// Don't need to notify, stay in null.
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
