kezhenxu94 commented on a change in pull request #7606:
URL: https://github.com/apache/skywalking/pull/7606#discussion_r698314849
##########
File path:
oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/UninstrumentedGatewaysConfig.java
##########
@@ -62,13 +61,17 @@ private void activeSetting(String config) {
log.debug("Updating using new static config: {}", config);
}
this.settingsString.set(config);
- onGatewaysUpdated(parseGatewaysFromYml(config));
+ if (config != null) {
+ onGatewaysUpdated(parseGatewaysFromYml(config));
+ } else {
+ onGatewaysUpdated(parseGatewaysFromYml(""));
+ }
Review comment:
nit: we can leverage `com.google.common.base.Strings.nullToEmpty(config)`
```suggestion
onGatewaysUpdated(parseGatewaysFromYml(Strings.nullToEmpty(config)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
