wu-sheng commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-docker/pull/24#discussion_r703503590
##########
File path: base/Dockerfile
##########
@@ -13,22 +13,14 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-ARG tag
FROM adoptopenjdk/openjdk11:alpine AS base
ARG version
RUN echo "Building Apache SkyWalking ${version}"
ENV SKYWALKING_VERSION=${version}
-
-FROM base AS es6
-RUN echo "This is the stage that build the es6 image"
ENV SKYWALKING_TGZ=apache-skywalking-apm-${SKYWALKING_VERSION}.tar.gz
-FROM base AS es7
-RUN echo "This is the stage that build the es7 image"
-ENV SKYWALKING_TGZ=apache-skywalking-apm-es7-${SKYWALKING_VERSION}.tar.gz
-
-FROM ${tag} AS build
+FROM base AS build
Review comment:
This is caused by ASF release process. Because in the old days, we need
to change script for every release(tag name or some parameters), because this
repo exists for years even before we support all configurations through system
environments. So, you could image how this complex every time this docker push
is.
Actually, for the current status, we don't need a new script, we just need a
tag or commit id as import to package and push the image. It is reasonable for
me to consider achieving this repo from now, and establish all things in those
repositories you mentions.
Once you decide to go into this directly, please send a notification(Lazy
Consensus) mail to the dev ml. We could directly work in your proposed way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
