wu-sheng commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-docker/pull/24#discussion_r703938714



##########
File path: base/Dockerfile
##########
@@ -13,22 +13,14 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-ARG tag
 
 FROM adoptopenjdk/openjdk11:alpine AS base
 ARG version
 RUN echo "Building Apache SkyWalking ${version}"
 ENV SKYWALKING_VERSION=${version}
-
-FROM base AS es6
-RUN echo "This is the stage that build the es6 image"
 ENV SKYWALKING_TGZ=apache-skywalking-apm-${SKYWALKING_VERSION}.tar.gz
 
-FROM base AS es7
-RUN echo "This is the stage that build the es7 image"
-ENV SKYWALKING_TGZ=apache-skywalking-apm-es7-${SKYWALKING_VERSION}.tar.gz
-
-FROM ${tag} AS build
+FROM base AS build

Review comment:
       @kezhenxu94 Another tip, we need some update at here, 
https://github.com/apache/skywalking-kubernetes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to