wu-sheng commented on a change in pull request #68:
URL:
https://github.com/apache/skywalking-satellite/pull/68#discussion_r714054167
##########
File path: plugins/client/grpc/client.go
##########
@@ -100,8 +102,15 @@ func (c *Client) Prepare() error {
"client_name": Name,
})})
+ // server address resolver
+ resolvers.RegisterAllGrpcResolvers()
+
// connect to server
- client, err := grpc.Dial(c.ServerAddr, *cfg...)
+ target, err := resolvers.BuildTarget(&c.ServerFinderConfig)
Review comment:
Notice, this target could be changed dynamically. Such as in k8s, a
domain name of services could have dynamic list of pods IP eventually. We need
to resolve this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
